Skip to content

Shard 2603 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Shard 2603 #33

wants to merge 2 commits into from

Conversation

kun6fup4nd4
Copy link

@kun6fup4nd4 kun6fup4nd4 commented Jul 16, 2025

PR Type

enhancement, bug fix


Description

  • Switch all #[cfg(debug)] to #[cfg(feature = "debug")]

  • Update Node.js engine requirement to 20.19.3

  • Improve feature flag consistency for debug logging

  • Minor code maintenance and dependency update


Changes walkthrough 📝

Relevant files
Enhancement
lib.rs
Use feature flag for debug logging in lib.rs                         

shardus_net/src/lib.rs

  • Replace all #[cfg(debug)] with #[cfg(feature = "debug")]
  • Ensures debug logging is controlled by a feature flag
  • +3/-3     
    ring_buffer.rs
    Feature-gate debug logging in ring_buffer.rs                         

    shardus_net/src/ring_buffer.rs

  • Replace #[cfg(debug)] with #[cfg(feature = "debug")] for logging
  • Ensures debug output is feature-gated
  • +2/-2     
    shardus_net_sender.rs
    Feature-gate debug logging in shardus_net_sender.rs           

    shardus_net/src/shardus_net_sender.rs

  • Replace all #[cfg(debug)] with #[cfg(feature = "debug")]
  • Ensures debug logs are only compiled with the feature enabled
  • +6/-6     
    Dependencies
    package.json
    Upgrade Node.js engine version in package.json                     

    package.json

  • Update Node.js engine version from 18.19.1 to 20.19.3
  • Maintains up-to-date dependency requirements
  • +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🏅 Score: 94
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Node.js Engine Update

    The Node.js engine requirement has been updated to 20.19.3. Ensure that all build, CI, and deployment environments are compatible with this version and that no dependencies break due to this change.

      "node": "20.19.3"
    },
    Feature Flag Consistency

    The switch from #[cfg(debug)] to #[cfg(feature = "debug")] for conditional logging is applied throughout. Confirm that the build and deployment processes properly set the debug feature flag as intended, and that debug logging is not unintentionally enabled or disabled.

    #[cfg(feature = "debug")]
    use log::info;
    //use log::LevelFilter;

    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant