SHARD-2140: add unstakeCooldown logic

[PudgyPug]

PR Type

enhancement, bug fix

---

Description

• Implemented unstake cooldown logic in StakeDisplay.

• Added unstakeInterval to AccountStakeInfo model.

• Introduced Constants for managing local storage keys.

• Enhanced tooltip logic for unstake button.

---

Changes walkthrough 📝

	Relevant files
Enhancement	StakeDisplay.tsx Implement unstake cooldown and enhance tooltips                    components/molecules/StakeDisplay.tsx Added unstake cooldown logic and tooltip updates. Introduced Constants for local storage management. Modified button disable logic based on cooldown. +50/-11  useUnstake.ts Add unstake cooldown storage logic                                              hooks/useUnstake.ts Set local storage item for unstake cooldown. Imported Constants for local storage key management. +2/-0      account-stake-info.ts Extend AccountStakeInfo with unstakeInterval                          model/account-stake-info.ts Added unstakeInterval property to interface. +1/-0
Miscellaneous	useStake.ts Clean up unused imports                                                                    hooks/useStake.ts Removed unused error handling imports. +0/-2
Configuration changes	constants.ts Add Constants for local storage keys                                          utils/constants.ts Introduced Constants object for key management. +3/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🏅 Score: 85

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Local Storage Usage The use of local storage for managing the unstake cooldown might lead to inconsistencies if the user accesses the application from different devices or browsers. Consider using a more centralized storage solution. useEffect(() => { const handleStorageChange = (e: StorageEvent) => { if (e.key === Constants.UNSTAKE_COOLDOWN_KEY) { setLastUnstake(e.newValue ? parseInt(e.newValue) : 0) } } window.addEventListener('storage', handleStorageChange) return () => window.removeEventListener('storage', handleStorageChange) }, []) Tooltip Logic The tooltip logic for the unstake button is complex and might be difficult to maintain. Consider refactoring for clarity and maintainability. function unstakeTooltip() { if (hasNodeStopped) { if (nodeStatus?.stakeState?.unlocked === false && nodeStatus?.stakeState?.remainingTime > 0) { return `Node is currently stopped and is being removed from the active validator list. Please wait for another ${formatRemainingTime( nodeStatus.stakeState.remainingTime )} before you can remove your stake.` } if (cooldown > 0) { return `You have recently removed your stake. Please wait for another ${formatRemainingTime( cooldown )} before you can remove your stake.` } } return 'It is not recommended to unstake while validating. If absolutely necessary, use the force remove option in settings to remove stake (Not Recommended).'

[github-actions]

Suggestion: Ensure that stakeInfo.unstakeInterval and lastUnstakeTime are valid numbers before performing arithmetic operations to prevent potential runtime errors. [possible issue, importance: 7]

Suggested change

	const cooldown = stakeInfo.unstakeInterval - (Date.now() - lastUnstakeTime)
	return cooldown > 0 ? cooldown : 0
	const cooldown = (typeof stakeInfo.unstakeInterval === 'number' && typeof lastUnstakeTime === 'number')
	? stakeInfo.unstakeInterval - (Date.now() - lastUnstakeTime)
	: 0;
	return cooldown > 0 ? cooldown : 0;

[github-actions]

Suggestion: Verify that handleStorageChange is properly defined and handles all potential edge cases, such as null or undefined values for e.newValue. [general, importance: 6]

Suggested change

	window.addEventListener('storage', handleStorageChange)
	return () => window.removeEventListener('storage', handleStorageChange)
	window.addEventListener('storage', handleStorageChange)
	return () => window.removeEventListener('storage', handleStorageChange)
	function handleStorageChange(e: StorageEvent) {
	if (e.key === Constants.UNSTAKE_COOLDOWN_KEY) {
	const newValue = e.newValue ? parseInt(e.newValue) : 0;
	if (!isNaN(newValue)) {
	setLastUnstake(newValue);
	}
	}
	}