SHARD-1842: better error messaging around Stake Lock

[PudgyPug]

PR Type

Enhancement

---

Description

• Added stakeable field to NodeStatus for restake cooldown.

• Implemented isStakeLocked and isRestakeForbidden checks in StakeDisplay.

• Updated UI to display restake cooldown messages.

• Refactored tooltip logic for stake lock status.

---

Changes walkthrough 📝

Relevant files

Enhancement

StakeDisplay.tsx Implement stake lock and restake cooldown logic                    components/molecules/StakeDisplay.tsx Added isStakeLocked and isRestakeForbidden checks. Updated button states and tooltips based on stake status. Displayed cooldown messages for restaking. +12/-3    node-status.ts Extend NodeStatus with restake cooldown properties              model/node-status.ts Added stakeable field to NodeStatus. Included restake cooldown properties. +5/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🏅 Score: 95

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review UI Logic Enhancement The logic for disabling buttons and displaying tooltips has been enhanced with new conditions for isStakeLocked and isRestakeForbidden. Ensure these conditions are correctly implemented and tested. const isStakeLocked = nodeStatus?.stakeState?.unlocked === false && nodeStatus?.stakeState?.remainingTime > 0 const isRestakeForbidden = nodeStatus?.stakeable?.restakeAllowed === false && nodeStatus?.stakeable?.remainingTime > 0 const isRemoveButtonDisabled = (!hasStakeOnDifferentNode && (!hasNodeStopped || !nodeStatus?.stakeState || !nodeStatus?.stakeState.unlocked)) || stakeForConnectedAddressOrNode === 0 || cooldown > 0 function unstakeTooltip() { if (hasNodeStopped) { if (isStakeLocked) { return `Node is currently stopped and is being removed from the active validator list. Please wait for another ${formatRemainingTime(

[github-actions]

Suggestion: Ensure that nodeStatus is defined before accessing its properties to prevent potential runtime errors. [possible issue, importance: 7]

Suggested change

	const isStakeLocked = nodeStatus?.stakeState?.unlocked === false && nodeStatus?.stakeState?.remainingTime > 0
	const isRestakeForbidden = nodeStatus?.stakeable?.restakeAllowed === false && nodeStatus?.stakeable?.remainingTime > 0
	const isStakeLocked = nodeStatus && nodeStatus.stakeState?.unlocked === false && nodeStatus.stakeState?.remainingTime > 0
	const isRestakeForbidden = nodeStatus && nodeStatus.stakeable?.restakeAllowed === false && nodeStatus.stakeable?.remainingTime > 0