Abort on panic #1570
Open
Abort on panic #1570
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help both runtime performance and side of the executable. And I can't think of a reason why we would need unwinding on panic in release builds.
From documentation of the tikv-jemallocator project: > The project is also published as jemallocator for historical reasons. The two crates are the same except names. > For new projects, it's recommended to use tikv-xxx versions instead.
Owner
|
Wouldn't this make bug reports harder to debug, or can we still get stacktraces? |
Collaborator
|
panic=abort still gives a backtrace, you just can't catch_unwind() |
Owner
|
Ok, in this case I'm fine with the change. Thank you |
Collaborator
Author
|
hmmm, actually it does look like the stack trace is less useful if panic=abort. It shows you where the panic happened, but not. I added a panic to output.rs and ran with panic=abort and with panic=unwind. RUST_BACKTRACE=1:with panic=abort: with panic=unwind: Also note that it looks like with "unwind" it flushes stdout before exiting, but with abort it doesn't. I'm not sure how much we care about that. RUST_BACKTRACE=fullwith panic=abort: with panic=unwind: Notice that with panic=abort, it does include the location of the actual panic, but not frames higher in the stack. So the question is, is it worth the cost in performance to have better stack traces from panics in release builds. I'm inclined to think that we see panics rarely enough, that it may be worth using abort in release builds, and if someone encounters a panic have them run with a debug build with panic=unwind to get a better stacktrace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help both runtime performance and side of the executable.
And I can't think of a reason why we would need unwinding on panic in
release builds.