fix: --print0 now works with --exec #1805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you use --print0 with --exec, it will now print a \0 between each set of commands run. That is, between the output for the commands run for each found item. Fixes: sharkdp#1797
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue where --print0 flag did not work properly with --exec commands. The fix ensures that when both flags are used together, a null character (\0) is printed between the output of each found entry's command execution.
Key changes:
- Removed mutex-based output synchronization in favor of a simpler approach
- Modified the output buffer to handle null separators directly
- Added test coverage for the new
--print0with--execfunctionality
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/walk.rs | Simplified thread spawning by removing mutex parameter |
| src/exec/mod.rs | Updated execute method to accept null_separator boolean instead of mutex |
| src/exec/job.rs | Removed mutex parameter and passed config.null_separator to execute |
| src/exec/command.rs | Refactored OutputBuffer to handle null separators and removed mutex dependency |
| tests/tests.rs | Added test case for --print0 with --exec functionality |
| doc/fd.1 | Updated documentation to explain --print0 behavior with --exec |
| CHANGELOG.md | Added changelog entry for the bug fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tmccombs
commented
Oct 3, 2025
| } | ||
| // While this lock is active, this thread will be the only thread allowed | ||
| // to write its outputs. | ||
| let _lock = self.output_permission.lock().unwrap(); |
Collaborator
Author
There was a problem hiding this comment.
I'm pretty sure this lock was redundant, since we are acquiring the lock for stdout anyway.
tavianator
approved these changes
Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use --print0 with --exec, it will now print a \0 between each set
of commands run. That is, between the output for the commands run for
each found item.
Fixes: #1797