Add plot_benchmarks scripts #806
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script is intended for a collection of hyperfine JSON files where multiple benchmarks were run for a selected group of commands.
sharkdp
reviewed
Mar 9, 2025
| import matplotlib.pyplot as plt | ||
| import numpy as np | ||
|
|
||
| parser = argparse.ArgumentParser(description=__doc__) |
There was a problem hiding this comment.
Should the comment above be a docstring in order for this to work?
sharkdp
reviewed
Mar 9, 2025
Comment on lines
+21
to
+23
| parser.add_argument( | ||
| "files", nargs="+", type=pathlib.Path, help="JSON files with benchmark results" | ||
| ) |
There was a problem hiding this comment.
Maybe we could add a note here that all files must include results with the same commands? Or maybe that should be described in the top-level doc string?
sharkdp
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script is intended for a collection of hyperfine JSON files where multiple benchmarks were run for a selected group of commands.
There are various projects that use such graphs:
https://github.com/rui314/mold?tab=readme-ov-file#mold-a-modern-linker
https://github.com/gimli-rs/addr2line?tab=readme-ov-file#performance
A sample output graph from the suggested script:
