Skip to content

Conversation

@glemieux
Copy link

Description:

This PR updates the check on the call to CNPAdjustFRootTargets based on the status of either FATES or the host land model nutrient supplementation. As such, the bulk of the lines of code is around retrieving the value of the supplementation status flag through the API.

Collaborators:

@rgknox provided the logic check design that is key to this PR

Expectation of Answer Changes:

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@glemieux
Copy link
Author

glemieux commented Mar 28, 2025

@sharma-bharat this PR update will need to be run with an associated code update on the ELM side. That PR is currently in draft form: E3SM-Project/E3SM#7182. I would like to have you test out the new setup, but it's slightly complicated by the fact E3SM is currently lagging behind the current fates tag. I'll need to create a special testing branch that brings E3SM up-to-date so that we can run with these new checks. I'll keep you posted, but I should be able to put that together in a day or so.

@glemieux
Copy link
Author

glemieux commented May 5, 2025

@sharma-bharat this PR update will need to be run with an associated code update on the ELM side. That PR is currently in draft form: E3SM-Project/E3SM#7182.

FYI, E3SM-Project/E3SM#7182 should be good to test against without needing a special branch now.

@glemieux
Copy link
Author

Closing per NGEET#1443

@glemieux glemieux closed this Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant