Circular download progress at dl button, ctrl click to open NewTab, #95
Conversation
|
remove this 3dot chars ,, from menu button..
|
blackholeearth
changed the title
blackholeearth
changed the title
|
[bordered texbox color , corner rounding radius fix.]
|
blackholeearth
force-pushed
the
circular_downloadProgress_atbutton
branch
from
f97fa7f to
d9dd05e
Compare
|
fixed residue fav icon, of previos visited site:: [in this case it was google:] problem site: https://unsplash.com/s/photos/optimization
|
blackholeearth
force-pushed
the
circular_downloadProgress_atbutton
branch
from
7c930a8 to
caf7a7f
Compare
blackholeearth
force-pushed
the
circular_downloadProgress_atbutton
branch
from
caf7a7f to
6bdd422
Compare
|
We should not show the "na" icon. Just make the icon null and then the tab will automatically hide the icon. The circular progress button is good, but can it be made the same width and height. Currently its a bit wide (squished) and that looks a bit ugly. |
src/Managers/FavIconManager.cs
Outdated
| var favnf = new Bitmap(16, 16); | ||
| var favg = Graphics.FromImage(favnf); | ||
|
|
||
| favg.FillRectangle(Brushes.Beige,0,0,favnf.Width,favnf.Height); | ||
| favg.DrawString("na", new Font( SystemFonts.DefaultFont.FontFamily,7f),Brushes.Black,0,0); | ||
|
|
||
| NotFound_favico = favnf.ToByteArray(ImageFormat.Png) ; | ||
|
|
There was a problem hiding this comment.
remove this. this icon is not required. just set the tab image to null and it will hide the icon.
src/Managers/FavIconManager.cs
Outdated
| // NOT FOUND! | ||
| //if you dont do this, there is residue favicon from previous Website. | ||
| iconBitmap = NotFound_favico; |
There was a problem hiding this comment.
at this point set iconBitmap to null and that should work hopefully.
There was a problem hiding this comment.
hopefully. ?! i hope.. if it(effects of null) spreads too much .. ill leave it as it is...
There was a problem hiding this comment.
spread over.. but fixed it.
agree.. if its safe to do .. do it.... since i didnt code that area ,, i just was alitle bit cautious...
but . it look good on my pc... as i saild i am on 1080p 125dpi ?? (16:9 aspectratio ) |
|
here square mod
|
tabnew newtab there was 2 conflicted naming... made it all NewTab.
…previous websites residue fav.
…ior..
enum{
AutoDetect, CustomProxy, NoProxy,
}
blackholeearth
force-pushed
the
circular_downloadProgress_atbutton
branch
from
d8d46b6 to
19b41c4
Compare
blackholeearth
changed the title
|
Ok, your changes look good. Thanks and merged! |
currentDownloadingProgress2.mp4
summary