Merge pull request #31 from Dronablo/fix_hang_on_small_input

Fix hang when recognize_song feed with less than 8ms sound

shazamio/api.py

@@ -267,6 +267,10 @@ async def recognize_song(
         audio = self.normalize_audio_data(song)
         signature_generator = self.create_signature_generator(audio)
         signature = signature_generator.get_next_signature()
+
+        if len(signature_generator.input_pending_processing) < 128:
+            return {"matches": []}
+
         while not signature:
             signature = signature_generator.get_next_signature()
         results = await self.send_recognize_request(signature)

tests/test_recognize.py

@@ -1,4 +1,6 @@
 import pytest_asyncio
+from pydub import AudioSegment
+from io import BytesIO
 
 from shazamio import Shazam
 from shazamio.utils import get_file_bytes
@@ -23,3 +25,19 @@ async def test_recognize_song_bytes(song_bytes: bytes):
 
     assert out.get("matches") != []
     assert out["track"]["key"] == "549679333"
+
+
+async def test_recognize_song_too_short():
+    short_audio_segment = AudioSegment.from_file(
+        file=BytesIO(b"0" * 126),
+        format="pcm",
+        sample_width=2,
+        frame_rate=16000,
+        channels=1,
+    )
+
+    shazam = Shazam()
+    out = await shazam.recognize_song(data=short_audio_segment)
+
+    assert out.get("matches") == []
+    assert "track" not in out