Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 71: separated count votes functions #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edegeyer
Copy link

@edegeyer edegeyer commented Aug 3, 2020

#71 implementation of the suggested changes

@shellfly
Copy link
Owner

shellfly commented Aug 3, 2020

@edegeyer The changes break backward compatibility and also introduce duplicate code. I would like to do it like this:

def count_up(self):
    return self.count(self, UP)
def count_down(self):
    return self.count(self, DOWN)

Also, at first this project doesn't support down vote, that's why the default counts up actions. The README is not updated, do you think mention it in document is better than add two extra methods?

@edegeyer
Copy link
Author

edegeyer commented Aug 3, 2020

Mentioning this in the README would definitely help, because for example I wasn't aware about it, as the action "DOWN" occurs and Downvotes can be stored/made.
For me personally, it would be more useful, if Downvoting is fully supported and would be happy to help with the steps towards a full support of that function

@shellfly
Copy link
Owner

shellfly commented Aug 3, 2020

@edegeyer There are two fields num_vote_up and num_vote_down added when implementing down vote. They can be used to replace the count api now.
If you're willing to update the PR to improve the README, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants