Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup fastbin_dup_consolidate and prepare it for glibc version 2.41 #202

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

k4lizen
Copy link
Contributor

@k4lizen k4lizen commented Jan 31, 2025

Handles: #200

Clarified some language to make it more clear this isn't a technique that (in general) gives tcache double free -> tcache poison. Cleaned up the explanation a bit.

I didn't touch versions 2.24 and 2.23 (which don't have tcache).

@Kyle-Kyle
Copy link
Contributor

Hi, the change looks good. But it seems there are some extra comments related to tcache-poisoning in the file, such as

// We would have to allocate this to be able to do tcache poison later, since we need at least 2 chunks in a bin to do it.
// void* ppoison = malloc(CHUNK_SIZE);

Since tcache-poisoning is another technique, and it is kinda confusing to explain another technique in another one. Can you please remove them before I hit merge?

@k4lizen
Copy link
Contributor Author

k4lizen commented Feb 3, 2025

Alright

@k4lizen
Copy link
Contributor Author

k4lizen commented Feb 20, 2025

@Kyle-Kyle no rush but just a reminder in case you forgot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants