-
Notifications
You must be signed in to change notification settings - Fork 97
table-view template #3444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
table-view template #3444
Conversation
…atiner of the filter items from block to flex
WalkthroughThe project file Changes
Sequence Diagram(s)Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
shesha-core/src/Shesha.Application/Shesha.Application.csproj (1)
131-133
: Maintain chronological ordering of EmbeddedResource entries
The new<EmbeddedResource>
entries forpackage20250623_1415.shaconfig
andpackage20250623_1750.shaconfig
followpackage20250618_1441.shaconfig
. Confirm this ordering remains chronological as more migrations are added.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
shesha-core/src/Shesha.Application/Shesha.Application.csproj
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build-attempt
🔇 Additional comments (1)
shesha-core/src/Shesha.Application/Shesha.Application.csproj (1)
84-84
: Embedding Excel template as resource looks correct
You’ve removedExcel\template.xlsx
from<None>
and added it under<EmbeddedResource>
, ensuring it’s packaged into the assembly. Consider grouping the Excel resource lines together with related entries for improved readability.Also applies to: 134-134
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hlakudi200
- Please attach an url of the GitHub issue you are addressing in this PR
- Compilation of back-end fails because of missing file package20250623_1415.shaconfig
URL to issue |
Hi @hlakudi200. Changes made in this PR don't address the issue you mentioned. Updated templates will affect only forms created from scratch. |
Hi @IvanIlyichev , this issue has with the been addressed by @Tshepiso-R migration of display and wrap by czwe-01 · Pull Request #3468 · shesha-io/shesha-framework |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hlakudi200.
The code is still not compilable
Hi @IvanIlyichev , this issue has with the been addressed by @Tshepiso-R #3468
Are you changes still make sense if the issue has been addressed?
Configured the table-view template by setting the filtering components container to use flex layout and then exported the .shaconfig file for embedding into the Shesha.Application.
Summary by CodeRabbit