SoraVideoSource で RTP Timestamp を設定しないように修正 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voluntas
requested changes
Oct 13, 2024
| @@ -67,6 +67,8 @@ | |||
| - @voluntas | |||
| - [ADD] examples に E2E テストを追加する | |||
| - @voluntas | |||
| - [FIX] SoraVideoSource で RTP Timestamp を設定しないように修正 | |||
There was a problem hiding this comment.
Pull-Request の description に書いてくれた内容も CHANGES にお願いします。
Pull-Request の description はソースコードとは分離してしまってるので、CHANGES にしっかり書くの大事です。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SoraVideoSource でこの段階では値が決まらないはずの RTP Timestamp がフレームに設定されていたので修正します。
libwebrtc 内でもデコーダーがデコードした際に受信した RTP Timestamp を設定することに使用しており、キャプチャーでは使用されていませんでした。