Address golangci-lint findings
#317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add check for error and fail if an error occurs. Signed-off-by: Matthias Diester <[email protected]>
Disable check for whether or not a package comment was written, since its a CLI and not a library component. Signed-off-by: Matthias Diester <[email protected]>
Simplify code as suggested by linter to use verb directly. Signed-off-by: Matthias Diester <[email protected]>
HeavyWombat
added
the
kind/cleanup
pull-request-size
bot
added
the
size/L
Use the same Gomega import name. Use Gomega matcher for calls that return an error. Signed-off-by: Matthias Diester <[email protected]>
Remove function that is apparently unused. Signed-off-by: Matthias Diester <[email protected]>
Add comments where comments are missing for exported functions. Signed-off-by: Matthias Diester <[email protected]>
Use command-line flag variables for command-line flags where the string was defined multiple times. Rename variables to better match their content. Ignore error for `MarkDeprecated` calls, since we use constant strings. Signed-off-by: Matthias Diester <[email protected]>
HeavyWombat
force-pushed
the
address/golangci-lint-findings
branch
from
71bd6e7 to
fd2b8f8
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes