Skip to content

Fix shipwright-io#314: update k8s to v0.33 #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

satyamg1620
Copy link

@satyamg1620 satyamg1620 commented May 31, 2025

Changes

Fixes CLI: update k8s to v0.33 #314
go.mod k8s dependencies: v0.30.9 to v0.33.0
Added ExecuteWithContext required method in fake_remote_executor.go

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 31, 2025
Copy link
Contributor

openshift-ci bot commented May 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qu1queee for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@satyamg1620 satyamg1620 force-pushed the fix-issue-314-update-k8s branch from e558826 to a4aa161 Compare May 31, 2025 19:16
@SaschaSchwarze0
Copy link
Member

Thanks @satyamg1620 for your work. Unfortunately, the issue you have been assigned to was not created correctly. In preparation of releases, we do not bump to the latest k8s version as we're still supporting older versions and the client should not be too new. Also, in this specific case, the k8s bump would mean that we would also need to start relying on Go 1.24 which we have not agreed on for the Shipwright v0.16 release.

We'll keep your changes in mind when we finally bump to >=0.33 for the necessary ExecuteWithContext change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

CLI: update k8s to v0.33
2 participants