correcting golangci-lint and gosec issues

Fixing gosec issue

G601 (CWE-118): Implicit memory aliasing in for loop. (Confidence: MEDIUM, Severity: MEDIUM)

controllers/pipelinerun_controller.go

@@ -137,7 +137,7 @@ func (r *PipelineRunReconciler) Reconcile(
 	var triggeredBuilds = []filter.TriggeredBuild{}
 	if filter.PipelineRunAnnotatedNameMatchesObject(&pipelineRun) {
 		// extracting existing triggered-builds from the annotation, information needed to detect if
-		// the BuildRuns have already beeing issued for the PipelineRun
+		// the BuildRuns have already been issued for the PipelineRun
 		triggeredBuilds, err = filter.PipelineRunExtractTriggeredBuildsSlice(&pipelineRun)
 		if err != nil {
 			logger.V(0).Error(err, "parsing triggered-builds annotation")

pkg/filter/customrun.go

@@ -16,7 +16,7 @@ import (
 // ParamValues slice.
 func TektonCustomRunParamsToShipwrightParamValues(customRun *tknv1beta1.CustomRun) []v1alpha1.ParamValue {
 	paramValues := []v1alpha1.ParamValue{}
-	for _, p := range customRun.Spec.Params {
+	for i, p := range customRun.Spec.Params {
 		paramValue := v1alpha1.ParamValue{Name: p.Name}
 		if p.Value.Type == tknv1beta1.ParamTypeArray {
 			paramValue.Values = []v1alpha1.SingleValue{}
@@ -28,7 +28,7 @@ func TektonCustomRunParamsToShipwrightParamValues(customRun *tknv1beta1.CustomRu
 			}
 		} else {
 			paramValue.SingleValue = &v1alpha1.SingleValue{
-				Value: &p.Value.StringVal,
+				Value: &customRun.Spec.Params[i].Value.StringVal,
 			}
 		}
 		paramValues = append(paramValues, paramValue)

pkg/filter/pipelinerun.go

@@ -38,7 +38,7 @@ var (
 	TektonPipelineRunTriggeredBuilds = fmt.Sprintf("%s/pipelinerun-triggered-builds", Prefix)
 )
 
-// pipelineRunReferencesShipwright checks if the informed PipelineRun is reffering to a Shipwright
+// pipelineRunReferencesShipwright checks if the informed PipelineRun is referring to a Shipwright
 // resource via TaskRef.
 func pipelineRunReferencesShipwright(pipelineRun *tknv1beta1.PipelineRun) bool {
 	if pipelineRun.Status.PipelineSpec == nil {

pkg/inventory/search_result.go

@@ -10,7 +10,7 @@ import (
 
 // SearchResult contains a Inventory result item.
 type SearchResult struct {
-	BuildName  types.NamespacedName // build name maching criteria
+	BuildName  types.NamespacedName // build name matching criteria
 	SecretName types.NamespacedName // respective secret coordinates (for webhook)
 }