Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding linting and security scanners #64

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Adding linting and security scanners #64

merged 2 commits into from
Aug 28, 2023

Conversation

coreydaley
Copy link
Contributor

@coreydaley coreydaley commented Aug 14, 2023 •
edited
Loading

  • Adds golangci-lint
  • Adds gosec
  • Adds govulncheck
  • Adds make targets for each
  • Adds make verify target to run all verification checks

Fixes #49

Changes

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 14, 2023
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 14, 2023
@coreydaley
Copy link
Contributor Author

/kind cleanup

@openshift-ci openshift-ci bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none and removed release-note labels Aug 14, 2023
@coreydaley
Copy link
Contributor Author

@SaschaSchwarze0 @qu1queee
please take a look, once we have worked through this pull request and settled on a basic format I can tackle the others.

@coreydaley
Copy link
Contributor Author

We should also update the Required Status Checks section of the Branch Protection Rule for the main branch to include all of the referenced checks (and remove the two old names).

SaschaSchwarze0
SaschaSchwarze0 reviewed Aug 15, 2023
View reviewed changes
.github/workflows/security.yml Outdated Show resolved Hide resolved
.github/workflows/security.yml Outdated Show resolved Hide resolved
.github/workflows/verify.yaml Show resolved Hide resolved
@SaschaSchwarze0 SaschaSchwarze0 mentioned this pull request Aug 21, 2023
Closed
@coreydaley
Adding linting and security scanners
81b44af 
 - Adds golangci-lint
 - Adds gosec
 - Adds govulncheck
 - Adds make targets for each
 - Adds make verify target to run all verification checks
@coreydaley
correcting golangci-lint and gosec issues
457c607 
Fixing gosec issue

G601 (CWE-118): Implicit memory aliasing in for loop. (Confidence: MEDIUM, Severity: MEDIUM)
@coreydaley
Copy link
Contributor Author

Are there any other questions or concerns with this pull request that I can address?

@qu1queee
Copy link
Contributor

From refinement, to modify the branch protection settings.

@coreydaley coreydaley mentioned this pull request Aug 28, 2023
Closed
SaschaSchwarze0
SaschaSchwarze0 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2023
@SaschaSchwarze0 SaschaSchwarze0 merged commit 0892830 into shipwright-io:main Aug 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 approved these changes

@qu1queee qu1queee Awaiting requested review from qu1queee

Assignees

@SaschaSchwarze0 SaschaSchwarze0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Shipwright Overview
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add golang lint ci
3 participants
@coreydaley @qu1queee @SaschaSchwarze0