Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update triggers project #95

Merged

Conversation

SaschaSchwarze0
Copy link
Member

Changes

  • Updates shipwright-io/build to v0.13.0 plus necessary code changes
  • Updates some locations where Go version was not updated to 1.21
  • Updates the envtest version to a specific one that does not require Go 1.22

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

Bumps [github.com/shipwright-io/build](https://github.com/shipwright-io/build) from 0.12.0 to 0.13.0.
- [Release notes](https://github.com/shipwright-io/build/releases)
- [Commits](shipwright-io/build@v0.12.0...v0.13.0)

---
updated-dependencies:
- dependency-name: github.com/shipwright-io/build
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@SaschaSchwarze0 SaschaSchwarze0 added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label May 13, 2024
@openshift-ci openshift-ci bot requested review from otaviof and qu1queee May 13, 2024 18:42
Copy link
Contributor

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
Copy link
Member

@apoorvajagtap apoorvajagtap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider updating the go version for unit & integration test GHA as well?

@apoorvajagtap
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7b317e5 into shipwright-io:main Jun 17, 2024
6 checks passed
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-updates branch June 17, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants