use correct path lengths #1937
Open
use correct path lengths #1937
+52
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| volumeNameBufferLength = uint32(windows.MAX_PATH + 1) | ||
| volumePathBufferLength = volumeNameBufferLength | ||
| maxWarningsInDrive = 5 | ||
| maxVolumeNameLength = uint32(windows.MAX_PATH + 1) // this should be a GUID (50), but for safety I keep max_path |
There was a problem hiding this comment.
it's a guid in string format that represent the volume, as far as I know all volumes are in guid format, but it's not well specified in documentation, so I keep MAX_PATH in case a volume can have a name in a longer format.
| return partitionStats, err | ||
| } | ||
| drivesString := windows.UTF16ToString(lpBuffer) | ||
| drives := strings.Split(drivesString, "\x00") |
There was a problem hiding this comment.
all drive names are separated by an UTF-16 null character
| uintptr(0), | ||
| uintptr(0)) | ||
|
|
||
| lpBuffer := make([]uint16, bufferLen) |
There was a problem hiding this comment.
this fixes the call when you have many drives mounted and a buffer > windows.MAX_PATH
| uintptr(len(volumeName)), | ||
| uintptr(unsafe.Pointer(&serialNumber)), | ||
| uintptr(unsafe.Pointer(&maxComponentLength)), | ||
| uintptr(0), // serial numbrt |
There was a problem hiding this comment.
these data are not used, so it's better to don't request them
| return nil, fmt.Errorf("failed to get volume paths size for volume %s: %w", windows.UTF16ToString(volNameBuf), volumePathFirstErr) | ||
| } | ||
|
|
||
| volPathsBuf := make([]uint16, returnLen) |
There was a problem hiding this comment.
this fixes the call when a volume is mounted as a folder in a path longer than 256 characters
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to use correct paths/buffer lengths, consider that NTFS supports also paths longer than 256 (windows.MAX_PATH)