Skip to content

remove twig cache changing path #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2024
Merged

remove twig cache changing path #1361

merged 1 commit into from
Jul 2, 2024

Conversation

shyim
Copy link
Member

@shyim shyim commented Apr 18, 2024

This will be deprecated in Symfony 7.1, and it makes no sense to move it

@shyim shyim requested a review from Isengo1989 April 18, 2024 13:52
@Isengo1989
Copy link
Contributor

@shyim is it already removed and we are running 7.1 (since 7.1 is only dev so far) ?

@shyim
Copy link
Member Author

shyim commented Apr 18, 2024

we are running 7.0 and it will be deprecated in 7.1

@Isengo1989
Copy link
Contributor

@shyim I don't think this is used very commonly, but we will leave the PR open until the functionality is fully removed. I will add the label blocked for now.

@Isengo1989 Isengo1989 added the Blocked Block PRs from merging label Apr 22, 2024
@Isengo1989 Isengo1989 removed the Blocked Block PRs from merging label Jul 1, 2024
Copy link
Contributor

@Isengo1989 Isengo1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR 🎉

Merged as soon as the version is released

@bojanrajh bojanrajh merged commit 7d88cde into main Jul 2, 2024
8 checks passed
@bojanrajh bojanrajh deleted the shyim-patch-1 branch July 2, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants