feat: Improve plugin configuration article and add missing settings #1524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitelg
requested review from
h1k3r,
AydinHassan,
Isengo1989,
sushmangupta,
bojanrajh,
nfortier-shopware and
SilasHach
Fr34k9
reviewed
Oct 21, 2024
guides/plugins/plugins/plugin-fundamentals/add-plugin-configuration.md
Outdated
Show resolved
Hide resolved
mitelg
force-pushed
the
improve-plugin-config-article
branch
2 times, most recently
from
deb26c2 to
9ed7a28
Compare
AydinHassan
requested changes
Oct 21, 2024
guides/plugins/plugins/plugin-fundamentals/add-plugin-configuration.md
Outdated
Show resolved
Hide resolved
guides/plugins/plugins/plugin-fundamentals/add-plugin-configuration.md
Outdated
Show resolved
Hide resolved
guides/plugins/plugins/plugin-fundamentals/add-plugin-configuration.md
Outdated
Show resolved
Hide resolved
guides/plugins/plugins/plugin-fundamentals/add-plugin-configuration.md
Outdated
Show resolved
Hide resolved
mitelg
force-pushed
the
improve-plugin-config-article
branch
from
9ed7a28 to
c309a02
Compare
mitelg
force-pushed
the
improve-plugin-config-article
branch
from
c309a02 to
d624466
Compare
bojanrajh
approved these changes
Oct 22, 2024
AydinHassan
approved these changes
Oct 22, 2024
|
nice work @mitelg ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The article about the plugin configuration was a bit outdated. I added missing configs and updated some parts