Skip to content

Update storefront modal docs #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

tobiasberge
Copy link
Contributor

Docs about modal are slightly outdated in 6.6.

  • Update modal DOM structure to be aligned with Bootstrap 5.
  • Fix invalid button without closing element

Docs about modal are slightly outdated in 6.6.

Update modal docs to be aligned with Bootstrap 4.
@tobiasberge tobiasberge added the Improvement PR created to append/modify info in the existing article label Dec 4, 2024
@tobiasberge tobiasberge self-assigned this Dec 4, 2024
Copy link
Contributor

@Isengo1989 Isengo1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR @tobiasberge 🎉

@Isengo1989 Isengo1989 merged commit ffdcf08 into main Dec 5, 2024
8 checks passed
@Isengo1989 Isengo1989 deleted the update-storefront-modal-docs branch December 5, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement PR created to append/modify info in the existing article
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants