Use php configs in extension examples#2160
Use php configs in extension examples#2160Umut Dogan (umutdogan4291) wants to merge 9 commits intomainfrom
Conversation
| <service id="Shopware\Commercial\B2B\B2BSuiteMigration\Components\EmployeeManagement\EmployeeManagementMigrationConfigurator"> | ||
| <tag name="b2b.migration.configurator" priority="9000"/> | ||
| </service> | ||
| ```PHP |
There was a problem hiding this comment.
I think lowercase is common markdown syntax, right? In our docs the spellchecker just wants uppercase cause it thinks that it is part of a sentence
There was a problem hiding this comment.
In the warning this reference was mentioned. https://community.languagetool.org/rule/show/FILE_EXTENSIONS_CASE?lang=en&subId=1
But I think it's for using extension names in a normal sentence 🤔
| <tag name="document.renderer"/> | ||
| </service> | ||
| ```php | ||
| use Shopware\Core\Checkout\Document\Service\DocumentConfigLoader; |
There was a problem hiding this comment.
either write the whole file or do not use the use statements. I looks a bit off to have the use statements and then only having the $services->set call
| ->decorate(ElasticsearchProductDefinition::class) | ||
| ->args([ | ||
| service(MyProductEsDecorator::class . '.inner'), | ||
| service(\Doctrine\DBAL\Connection::class), |
There was a problem hiding this comment.
why not importing?
| </service> | ||
| ```php | ||
| $services->set(Swag\Example\Service\SwagService::class) | ||
| ->public() |
There was a problem hiding this comment.
I would not promote that. usually services should not be public
3 participants
No description provided.