Remove tracing-subscriber dep #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
remove_tracing_subscriber_dep
branch
from
921d98c
to
ff90c63
Compare
rukai
force-pushed
the
remove_tracing_subscriber_dep
branch
from
ff90c63
to
9718a62
Compare
conorbros
approved these changes
Feb 5, 2024
conorbros
approved these changes
Feb 5, 2024
cjrolo
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was used to setup a subscriber for the test itself.
But this crate should not be responsible for that, so we should remove the functionality and leave it up to the developer whether or not there should be a subscriber for the test code.
This does not affect the setting up of tracing for the application binary only for the test binary.