[SHRINKRES-343] Remove Arquillian Spacelift dependency #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xstefank
reviewed
Jul 24, 2024
| for (int i = 0; i < 3; i++) { | ||
| try { | ||
| downloaded = runDownloadExecution(mavenDistribution, target).await(); | ||
| } catch (ExecutionException ee) { | ||
| if (expectedSize == 0) { |
There was a problem hiding this comment.
I don't understand what are you doing here, but if you run this only only first iteration, then why not to move it before the loop.
There was a problem hiding this comment.
In case of IOException caused by the HttpURLConnection the block will be run again. Moving it before the loop would mean to have another loop for this case
petrberan
force-pushed
the
SHRINKRES-343
branch
from
94f40b7 to
42dc784
Compare
petrberan
force-pushed
the
SHRINKRES-343
branch
from
42dc784 to
0a657de
Compare
xstefank
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/SHRINKRES-343