Skip to content

Support marshalling a null URI #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YuviGold wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support marshalling a null URI #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scalar.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ type (
// MarshalJSON implements the json.Marshaler interface.
// The URI is a quoted string.
func (u URI) MarshalJSON() ([]byte, error) {
if u.URL == nil {
return []byte("null"), nil
}
return json.Marshal(u.String())
}

Expand Down
5 changes: 5 additions & 0 deletions scalar_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ func TestURI_MarshalJSON(t *testing.T) {
in githubv4.URI
want string
}{
{
name: "null",
in: githubv4.URI{},
want: `null`,
},
{
in: githubv4.URI{URL: &url.URL{Scheme: "https", Host: "example.org", Path: "/foo/bar"}},
want: `"https://example.org/foo/bar"`,
Expand Down