Custom icon adjustment in Drawing Tool

[Photon89]

For the moment there is just a fixed variable $dark_icons which controls which custom icon set is used. To do:

• Set icon choice from a system setting.
• Implement automatic background detection.
• Better handling of duplicate icons via symlinks.

[DarthGandalf]

Suggested change

	our $dark_icons = 1;
	my $dark_icons = 1;

[Photon89]

It spit errors with "my":

Global symbol "$dark_icons" requires explicit package name (did you forget to declare "my $dark_icons"?) at ./bin/shutter line 6020.
Execution of ./bin/shutter aborted due to compilation errors.
 at ./bin/shutter line 11118.

But the variable needs to be defined elsewhere anyway, I just put it there for a quick test.

[Photon89]

Never mind, the reason for the error was elsewhere, "my" also works. I will change it while putting the variable to a more sensible place.

[Photon89]

I added the radio buttons. For now the "auto" option is dysfunctional. The icons are set at Drawing Tool launch.

[Photon89]

The automatic detection seems to work really well! But I think that the menu option is still necessary for cases when it fails.

Now I wonder what is the fastest way to create a lot of symlinks. The contents of /share/shutter/resources/icons/drawing_tool and /share/shutter/resources/icons/drawing_tool_dark are almost identical, only five icons differ.

[DarthGandalf]

A for loop in zsh? :)

Or reading the icon could check one dir first, and if file doesn't exist read the other dir

[DarthGandalf]

Rather than passing 3 new bool parameters, let's pass only 1, then do the coloring depending on the value passed there

[Photon89]

Okay, should be fine now, please have a look!

[Photon89]

Rather than passing 3 new bool parameters, let's pass only 1, then do the coloring depending on the value passed there

Sorry, missed this one. I will have a look into it.

[Photon89]

Better this way?