Add profile and also Updated some code and removed issues #1230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to user preferred theme
…d the new custom theme change hook
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @Joyal-George-KJ! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
Soon the maintainers/owner will review it and provide you with feedback/suggestions.
|
@shyamtawli Requesting Review. |
|
@Joyal-George-KJ I am not able to change theme, have a look |
@shyamtawli Sorry for wasting your time it was caused by my negligence. Forgot to pass props to the toggle hook. Ready for the review now and Tested everything that I changed.
|
shyamtawli
approved these changes
Jul 14, 2025
|
@Joyal-George-KJ Thanks and sorry for late response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Came here to put my profile but found some problems so I solved it also added my profile too.
Problems Solved
There was this bug of not properly controlling theme when user first visit the website the theme icon has the moon icon meaning the theme should be dark but it still had the light theme and you have to press the theme toggle button twice to change the theme to dark.
Changed the defaultAvatar.png to defaultAvatar.webp.
There was a commented handle for user image not found but the implementation was wrong I have solved it and added the defaultAvatar as the default if user image not found.
added ID for search bar and filter dropdown for better form control and SEO.
Related Issues
Changes Proposed
Better Theme control and Removed the bug from it.
Default Image added.
Checklist
Screenshots
Canva Link to the Solution
Note to reviewers
Added comment to the code so that others can modify and understand the code.