-
Notifications
You must be signed in to change notification settings - Fork 5
Feature/wallet/tx func #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
let mnemonic_phrase = "summer summer summer summer summer summer summer summer summer summer summer summer summer summer summer summer summer summer summer summer summer summer summer summer"; | ||
let wallet = Wallet::new_mnemonic(mnemonic_phrase); | ||
let address = wallet | ||
.get_change_address(whisky_wallet::AddressType::Payment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allow selecting of wallet type feels little weird, how see @twwu123?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i refer this to mesh. if browser wallet, always BaseAddress. If not, either BaseAddress or EnterpriseAddress
https://github.com/MeshJS/mesh/blob/7fd4afcf287a30b561ffa0b503ec10ddc6683935/packages/mesh-wallet/src/mesh/index.ts#L229
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea i think this is fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Later we may overhaul wallet logic, just copy mesh logic for now
Thank you for contributing to Whisky! We appreciate your effort and dedication to improving this project. To ensure that your contribution is in line with the project's guidelines and can be reviewed efficiently, please fill out the template below.
Remember to follow our Contributing Guide before submitting your pull request.
Impl 4 additional functions in Wallet
Scope of Change
whisky
whisky-provider
whisky-wallet
whisky-csl
whisky-common
whisky-macros
whisky-js
Type of Change
Feature Change
new feature
Maintenance
Checklist
Additional Information