refactor: move state.State to public package
#56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkuozdemir
force-pushed
the
export-packages
branch
from
3a6936e to
ea068de
Compare
Export the state struct from the internal package into a public package. It is a dependency of the `ClusterServer` GRPC service - so to be able to import and use it, the state also needs to be exported. Signed-off-by: Utku Ozdemir <[email protected]>
utkuozdemir
force-pushed
the
export-packages
branch
from
ea068de to
85b6b27
Compare
Member
|
Does it make sense to export the entrypoint, i.e. |
Member
Author
Hm, maybe not exactly that, as lots of other things going on there, but probably exporting the code that builds the state + grpc server struct + storage as a single function could work. |
Member
yeah, I mean exactly something like that |
|
This PR is stale because it has been open 45 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export the state struct from the internal package into a public package. It is a dependency of the
ClusterServerGRPC service - so to be able to import and use it, the state also needs to be exported.