Closed
Conversation
Untersander
force-pushed
the
multipath-tools
branch
4 times, most recently
from
818d8fc to
d1213cb
Compare
frezbo
reviewed
Nov 14, 2025
frezbo
reviewed
Nov 14, 2025
frezbo
reviewed
Nov 14, 2025
frezbo
reviewed
Nov 14, 2025
frezbo
reviewed
Nov 14, 2025
frezbo
reviewed
Nov 14, 2025
frezbo
reviewed
Nov 14, 2025
frezbo
reviewed
Nov 16, 2025
frezbo
reviewed
Nov 16, 2025
storage/multipath-tools/patches/disable-exception-handling.patch
Outdated
Show resolved
Hide resolved
frezbo
reviewed
Nov 17, 2025
Untersander
force-pushed
the
multipath-tools
branch
from
49d202b to
f98c069
Compare
Contributor
Author
|
I updated the Maintainers file and the main README, please let us know if there's anything that should be done before this can be merged. |
Member
|
@SimLi1333 @Untersander is this good to go? |
contains multipathd and supporting binaries for Trident CSI Co-authored-by: Simon Linder <[email protected]> Signed-off-by: Jan Untersander <[email protected]>
Untersander
force-pushed
the
multipath-tools
branch
from
e580076 to
21f9385
Compare
Contributor
Author
Yes, we did the final validation of the libgcc change today and everything works as expected. |
Member
Okay, I'll work on getting this merged |
Member
|
Created #900 since we cannot push to a PR from org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings two new extensions multipath-tools, a daemon for iSCSI devices and trident-iscsi-tools which are a bunch of executables needed by the Trident CSI to work with iSCSI. It also adds a little change in the util-linux extension for another dependency of Trident.
The multipath-tools extension brings the userspace daemon part required for SAN multipath devices to work.
The additional required multipath kernel modules are already available in Talos(or at least the ones we need).
It continues work already started in PR #505 and brings the extension to a working state without pulling in everything.
This would probably also solve the issues #576 #467 which were closed as not planned and maybe #134 as well.
The second part with trident-iscsi-tools and the change to the util-linux extension brings in binaries expected to be on the host by the Trident CSI in the case of iSCSI connections. Together these changes allow for iSCSI connections via the Trident CSI.
These binaries should come with the Trident CSI itself in my opinion and we've already explored this and will also work on a PR on the Trident side.
With this I'm not quite sure what to do, as it's really specific to Trident itself and maybe hopefully not be required sometime in the future if we can get a PR merged in Trident.
I'm also happy to move this to a second PR as the multipath-tools extension will also be useful for users of other CSIs which want to use SAN multipath devices.
I also would be glad about pointers on how do you handle the testing of extensions, so we could add them to theses as well.
Thanks to @bzub and @aaroncirillo-cision for their previous work and @SimLi1333 for the help.