(WIP) feat: add aws-iam-authenticator extension #942
+467
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiomatavelli
force-pushed
the
feat/add-aws-iam-authenticator
branch
3 times, most recently
from
454d2f5 to
265ebc6
Compare
fabiomatavelli
changed the title
fabiomatavelli
force-pushed
the
feat/add-aws-iam-authenticator
branch
2 times, most recently
from
f6ae4f2 to
409c27c
Compare
Adds the [aws-iam-authenticator](kubernetes-sigs/aws-iam-authenticator) extension to Talos so it can generate the necessary certificates and kubeconfig, to be used with `kube-apiserver`, so users can authenticate in the cluster using AWS IAM roles.
fabiomatavelli
force-pushed
the
feat/add-aws-iam-authenticator
branch
from
409c27c to
e8cebbe
Compare
Member
|
@fabiomatavelli is this good for review? |
Author
|
@frezbo I'm still thinking if it would make sense to add this or not tbh. With the extension the process would be executed on all the nodes (worker and control-planes) as it requires the configuration to be present. So, I'm thinking if it makes sense to move forward with the extension or if providing the necessary files (certs and kubeconfig) during the bootstrap of the nodes would make more sense. |
Member
|
Cool, iterate and see how it goes, we've plenty of time before 1.13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the aws-iam-authenticator to Talos.