refactor(frontend): wait for signing keys instead of throwing #1923
Conversation
Instead of throwing an error when we try to make requests before signing keys are ready, we enter a loop to wait for keys to exist. This prevents errors and the need to handle them, as well as making requests fire immediately when keys are eventually ready. Signed-off-by: Edward Sammut Alessi <[email protected]>
| </a> | ||
|
|
||
| <OngoingTasks v-if="authorized" /> | ||
| <OngoingTasks /> |
There was a problem hiding this comment.
Minor side effect, now when waiting to create keys, you will see the ongoing tasks menu item, where as before you didn't. I think this was originally only being handled to not throw console errors, so unless we specifically do not want to show it at this moment, this is one less case to handle.
| // Enter a loop to wait for keys to be ready. | ||
| // Request will fire when we have keys. | ||
| return await new Promise<string>((resolve) => { | ||
| setTimeout(() => { |
There was a problem hiding this comment.
this might be a dumb question, but why can't we make a function not fire an exception on no keys, and just wait on its own?
or have two versions, one which waits and another one which throws an error?
There was a problem hiding this comment.
I'm trying to avoid the setTimeout loop here :)
There was a problem hiding this comment.
The setTimeout here is my version of waiting, it will essentially poll for keys every 100ms.
There are other ways to do it, could be with events & listeners for example, but I just went with the most straight forward option in front of me.
WDYT?
There was a problem hiding this comment.
I don't want to block the PR, I was just more curious if the Promise should not fail with "no keys" but itself wait for the keys to be establishes, avoiding the need to for polling.
There was a problem hiding this comment.
yeah, I'd also prefer some event handler instead
4 participants
Instead of throwing an error when we try to make requests before signing keys are ready, we enter a loop to wait for keys to exist. This prevents errors and the need to handle them, as well as making requests fire immediately when keys are eventually ready.