fix: prevent file descriptors leaks to child processes #9413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
added a commit
to smira/talos
that referenced
this pull request
Oct 1, 2024
See siderolabs#9413 Not sure how to turn this into a useful test. Signed-off-by: Andrey Smirnov <[email protected]>
Member
Author
|
I used #9414 to verify fixes |
See siderolabs#9412 I'll keep the issue open to track upstream PR status and remove replace directives. Signed-off-by: Andrey Smirnov <[email protected]>
dsseng
reviewed
Oct 1, 2024
dsseng
approved these changes
Oct 1, 2024
Unix4ever
approved these changes
Oct 1, 2024
Member
Author
|
/m |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9412
I'll keep the issue open to track upstream PR status and remove replace directives.