use improved implementation to get last TS and cleanup todos #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoessbauer
force-pushed
the
fm/cleanup-todos
branch
8 times, most recently
from
ab5a843 to
49e07a9
Compare
The version in debian bookworm is super-old, preventing us from using much needed meson features. As there is a more recent version in backports and this is only a built-time dependency, we switch to the version from backports. Signed-off-by: Felix Moessbauer <[email protected]>
We currently use an O(n) implementation to get the timestamp of the last record. If we have a version of libtracecmd that supports reverse iteration, use that instead, making the algorithm O(1). Signed-off-by: Felix Moessbauer <[email protected]>
We currently use version checks to see if the babeltrace library offers some symbols. We switch that over to directly checking for the symbols, as this is a more reliable way of doing it. Signed-off-by: Felix Moessbauer <[email protected]>
Signed-off-by: Felix Moessbauer <[email protected]>
fmoessbauer
force-pushed
the
fm/cleanup-todos
branch
from
49e07a9 to
87113aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.