Skip to content

Build/build docs 2 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2025
Merged

Build/build docs 2 #4

merged 2 commits into from
May 15, 2025

Conversation

@spike-rabbit
Copy link
Member

@spike-rabbit spike-rabbit commented May 15, 2025 •
edited
Loading

  1. Using uv instead of poetry. The main motivation is the availabilty of a gh actions (and it is supposed to be faster)
  2. Just building the docs. No publishing yet. This is another PRs job

Describe in detail what your merge request does and why. Add relevant
screenshots and reference related issues via Closes #XY or Related to #XY.

@spike-rabbit
build: use uv instead of poetry
2dc9223 
UV seems to be the nowadays better choice.
In addition, they also offer a dedicated GitHub action
which simplifies the usage for compared to poetry.
@spike-rabbit
build: build the documentation in CI
e8a541a
@spike-rabbit spike-rabbit marked this pull request as ready for review May 15, 2025 15:52
@spike-rabbit spike-rabbit mentioned this pull request May 15, 2025
Closed
1 task
timowolf
timowolf approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@timowolf timowolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I like it

@timowolf timowolf added the documentation Improvements or additions to documentation label May 15, 2025
@timowolf timowolf merged commit 0140416 into main May 15, 2025
8 of 9 checks passed
@fh1ch fh1ch deleted the build/build-docs-2 branch May 19, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timowolf timowolf timowolf approved these changes

@kfenner kfenner Awaiting requested review from kfenner

Assignees

@timowolf timowolf

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spike-rabbit @timowolf