feat(filter-bar): add disableAutoTranslation option to avoid unwanted translation#705
Conversation
53ca927 to
efc8886
Compare
efc8886 to
00e1f0e
Compare
|
@siemens/siemens-element-members Please review the approach here. Do you think this is a good solution to prevent user input from accidentially being translated when the entered text matches a TRANSLATION.KEY? |
| * Disables automatic translation of title and description text. | ||
| * When set to true, the title and description will be displayed as-is without |
There was a problem hiding this comment.
Please see in the comments above, we normally use links to refer to other properties when we do proper comments 👍
Also, please make sure the title and description fields are marked as TranslatableString types instead of plain string.
| * Disables automatic translation of title and description text. | |
| * When set to true, the title and description will be displayed as-is without | |
| * Disables automatic translation of {@link title} and {@link description} text. | |
| * When set to true, the {@link title} and {@link description} will be displayed as-is without |
|
I am actually more in favor of @spliffone idea provided in the initial issue. If they only need partial translation apps, need to translate manually. Is also not that hard. |
|
Please see #758. We plan to have a common marker instead of component specific solution. |
When user types a word that matches the translation keys then filter pill displays the actual translated value.
Using
disableAutoTranslationwill prevent automatic translation of filter pill text when it matches translation keys