Skip to content

Conversation

@mistrykaran91
Copy link
Member

@mistrykaran91 mistrykaran91 commented Sep 8, 2025

When user types a word that matches the translation keys then filter pill displays the actual translated value.
Using disableAutoTranslation will prevent automatic translation of filter pill text when it matches translation keys


@mistrykaran91 mistrykaran91 force-pushed the feat/add-disableAutoTranslation-property-to-avoid-translation-collision branch from 53ca927 to efc8886 Compare September 8, 2025 10:38
@github-actions
Copy link

github-actions bot commented Sep 8, 2025

@mistrykaran91 mistrykaran91 marked this pull request as ready for review September 8, 2025 10:51
@mistrykaran91 mistrykaran91 requested a review from a team as a code owner September 8, 2025 10:51
@mistrykaran91 mistrykaran91 force-pushed the feat/add-disableAutoTranslation-property-to-avoid-translation-collision branch from efc8886 to 00e1f0e Compare September 8, 2025 11:23
@kfenner
Copy link
Member

kfenner commented Sep 10, 2025

@siemens/siemens-element-members Please review the approach here. Do you think this is a good solution to prevent user input from accidentially being translated when the entered text matches a TRANSLATION.KEY?

Comment on lines +29 to +30
* Disables automatic translation of title and description text.
* When set to true, the title and description will be displayed as-is without
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see in the comments above, we normally use links to refer to other properties when we do proper comments 👍

Also, please make sure the title and description fields are marked as TranslatableString types instead of plain string.

Suggested change
* Disables automatic translation of title and description text.
* When set to true, the title and description will be displayed as-is without
* Disables automatic translation of {@link title} and {@link description} text.
* When set to true, the {@link title} and {@link description} will be displayed as-is without

@spike-rabbit
Copy link
Member

I am actually more in favor of @spliffone idea provided in the initial issue.
If apps don't want translation, they should provide the SiNoTranslateService.
This is consistent across all components. We should just document somewhere.

If they only need partial translation apps, need to translate manually. Is also not that hard.

@spike-rabbit
Copy link
Member

Please see #758. We plan to have a common marker instead of component specific solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants