fix(navbar-vertical-item): align badge in collapse state correctly #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljanner
force-pushed
the
fix/navbar-vertical-item-badge
branch
from
0f31561 to
ecd412b
Compare
ljanner
force-pushed
the
fix/navbar-vertical-item-badge
branch
from
ecd412b to
c8a7759
Compare
ljanner
force-pushed
the
fix/navbar-vertical-item-badge
branch
from
ecdd365 to
591961f
Compare
dr-itz
reviewed
Sep 12, 2025
projects/element-ng/navbar-vertical/si-navbar-vertical-item.component.ts
Outdated
Show resolved
Hide resolved
dr-itz
reviewed
Sep 12, 2025
projects/element-ng/navbar-vertical/si-navbar-vertical-item.component.scss
Show resolved
Hide resolved
ljanner
force-pushed
the
fix/navbar-vertical-item-badge
branch
from
591961f to
058c612
Compare
timowolf
approved these changes
Sep 15, 2025
Member
timowolf
left a comment
timowolf
left a comment
There was a problem hiding this comment.
Fantastic work. Many thanks.
The badge in the collapsed state is right aligned. If the badge value is over 99 it will be shown as "+99". To ensure consistency, the badge in the expanded state will also show "+99" for values over 99.
timowolf
force-pushed
the
fix/navbar-vertical-item-badge
branch
from
058c612 to
b7a9e14
Compare
Collaborator
|
🎉 This PR is included in version 48.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The badge in the collapsed state is right aligned.
If the badge value is over 99 it will be shown as "+99". To ensure consistency, the badge in the expanded state will also show "+99" for values over 99.
Example showcasing the badge with different character lengths and values: link