Skip to content

Conversation

@ofaruk84
Copy link
Collaborator

💡 What is the current behavior?

Attribute names of Pagination were not compatible with new version

GitHub Issue Number: #

🆕 What is the new behavior?

Updated the Pagination component to replace the ShowItemCount parameter with HideItemCount. Adjusted the rendering in PaginationTest.cs to use a lambda expression for parameters and modified the expected markup accordingly. Removed the show-item-count attribute in Pagination.razor to align with these changes.

image

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated
  • 🧪 Unit tests were added/updated and pass (dotnet test)
  • 🏗️ Successful compilation (dotnet build, changes pushed)

Updated the `Pagination` component to replace the `ShowItemCount` parameter with `HideItemCount`. Adjusted the rendering in `PaginationTest.cs` to use a lambda expression for parameters and modified the expected markup accordingly. Removed the `show-item-count` attribute in `Pagination.razor` to align with these changes.
@ofaruk84 ofaruk84 requested a review from emncnozge November 26, 2025 13:32
@emncnozge emncnozge merged commit ee274dc into siemens:master Nov 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants