Docs/modals usage guide #139
Draft
+258
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces detailed usage guides for loading modal, message modal, and custom modal components. Updates sidebar and tab labels for consistency, improves descriptions, and adds related links to progress indicator and toast guides for better documentation navigation.
Revised documentation for loading, message, and custom modals to improve clarity and update usage guidelines. Replaced old Figma illustration links with new ones and added three new illustration assets to the static/figma directory.
Collaborator
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive usage guides for the custom, loading, and message modal components, which is a great addition to the documentation. My review focuses on ensuring the new content aligns with the repository's documentation style guide. I've identified several areas for improvement, primarily concerning consistent phrasing, correct punctuation as per the style guide, and resolving a leftover TODO comment. These changes will help maintain the high quality and consistency of the documentation.
| | [Question delete](https://www.figma.com/design/wEptRgAezDU1z80Cn3eZ0o/iX-Documentation-illustrations?node-id=7351-3731&t=WHbXyipgpGwQbVsV-4) | Title: Are you sure you want to delete this item permanently?<br/>Variant: Question<br/>Buttons: primary danger button "Delete" and primary ghost button "Cancel" | | ||
| | [Question discard](https://www.figma.com/design/wEptRgAezDU1z80Cn3eZ0o/iX-Documentation-illustrations?node-id=7351-3947&t=WHbXyipgpGwQbVsV-4) | Title: Do you want to save your changes before leaving?<br/>Variant: Question<br/>Buttons: primary button "Save changes", secondary button "Cancel" and tertiary button "Discard" | | ||
|
|
||
| /*TODO Remove either bullet points or table*/ |
Contributor
There was a problem hiding this comment.
A TODO comment has been left in the documentation. Please resolve this before merging.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ix-docs into docs/modals-usage-guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 What is the current behavior?
There are no usage guides available for modals.
Jira issue: IX-3423
🆕 What is the new behavior?
👨💻 Help & support