-
Notifications
You must be signed in to change notification settings - Fork 117
Added fix for properties textarea-rows and textarea-width issues #2035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
varun-srinivasa
wants to merge
29
commits into
siemens:main
Choose a base branch
from
varun-srinivasa:textArea
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 27 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
1566ff1
Added fix for textarea rows and textarea width
varun-srinivasa 51f21ea
fixed lint
varun-srinivasa 79b69fa
updated failing VRT
varun-srinivasa 7819f60
Merge branch 'main' into textArea
varun-srinivasa 928c9f6
Update component-doc.json
varun-srinivasa 1a3a41a
updated failing componentdoc
varun-srinivasa 9e77b15
Merge branch 'textArea' of https://github.com/varun-srinivasa/ix intoโฆ
varun-srinivasa 30327fc
Delete packages/core/component-doc.json
varun-srinivasa 80d7989
Merge branch 'main' of https://github.com/varun-srinivasa/ix into texโฆ
varun-srinivasa 8b38b77
Merge branch 'textArea' of https://github.com/varun-srinivasa/ix intoโฆ
varun-srinivasa 1670bc5
Updated css to match width
varun-srinivasa ea14786
Updated VRT
varun-srinivasa 7f35f11
Merge branch 'main' into textArea
varun-srinivasa ef1301a
updated component-doc.json
varun-srinivasa 73ea18b
Merge branch 'textArea' of https://github.com/varun-srinivasa/ix intoโฆ
varun-srinivasa 6990aa6
Merge branch 'main' into textArea
varun-srinivasa 8dffbdf
updated component tests
varun-srinivasa 0c16634
fixed lint error
varun-srinivasa 04a5f11
Merge branch 'main' into textArea
varun-srinivasa aef6d6f
Create tasty-cups-argue.md
nuke-ellington bc51846
Merge branch 'main' into textArea
varun-srinivasa bc00a4c
updated textarea as per comments
varun-srinivasa 0fb17a8
Merge branch 'main' into textArea
varun-srinivasa 17502c7
Merge branch 'main' of https://github.com/varun-srinivasa/ix into texโฆ
varun-srinivasa 65f144b
resolved merge conflicts
varun-srinivasa 4aae78c
Merge branch 'textArea' of https://github.com/varun-srinivasa/ix intoโฆ
varun-srinivasa 55588e9
resolved merge conflicts
varun-srinivasa 0754b6b
updated textarea logic
varun-srinivasa 843103f
Merge remote-tracking branch 'origin/main' into textArea
danielleroux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@siemens/ix": patch | ||
| --- | ||
|
|
||
| Fix **ix-textarea** properties textarea-rows and textarea-width making sure their values get applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+167 Bytes
(100%)
...ap.e2e.ts/3rd-party-bootstrap-html-elements-1-chromium---classic-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+168 Bytes
(100%)
...p.e2e.ts/3rd-party-bootstrap-html-elements-1-chromium---classic-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
.../textarea/textarea.e2e.ts/textarea-disabled-1-chromium---classic-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...textarea/textarea.e2e.ts/textarea-disabled-1-chromium---classic-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
.../textarea/textarea.e2e.ts/textarea-readonly-1-chromium---classic-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...textarea/textarea.e2e.ts/textarea-readonly-1-chromium---classic-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of issues with the implementation for
textareaWidth:Dynamic updates are not handled: This logic only runs when the component loads. If the
textareaWidthprop is changed dynamically after the component has been mounted, the width will not update. To fix this, you should handle property changes using a@Watch('textareaWidth')decorator. I suggest extracting this logic into a private method and calling it from bothcomponentWillLoadand the new watcher method.Example:
Conflicting width styles: The
textareaWidthprop is still passed toTextareaElementand applied as an inlinewidthstyle on the<textarea>element inpackages/core/src/components/input/input.fc.tsx. This will override thewidth: 100%from the stylesheet and cause incorrect layout. You should remove thewidth: props.textareaWidthfrom thestyleobject inTextareaElementto allow the textarea to correctly fill its container.