Skip to content

Divide customizations recipe into smaller ones #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

colpane
Copy link
Contributor

@colpane colpane commented Jul 10, 2025

To not get unnecessary features in customizations-example, it is divided into smaller recipes that include feature specific changes. Downstream layers can easily get which feature they want and still override anything they want.

To use latest version of change-root-homedir, isar and isar-cip-core are updated, too.

@colpane
Copy link
Contributor Author

colpane commented Jul 10, 2025

@jan-kiszka @huaqianli @BaochengSu let me know your feedback.


inherit dpkg-raw

DESCRIPTION = "IOT2050 reference image customizations ssh"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only enables direct login as root via ssh - maybe make description and even recipe name more specific?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -29,13 +29,13 @@ repos:

isar:
url: https://github.com/ilbers/isar
commit: 938dab363006529f0b5296dfbc09ef306fc8c3d7
commit: 8e3122249a52db470efb32b92ed9c44e4b758712
Copy link
Collaborator

@BaochengSu BaochengSu Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to mention in the commit message the motivations or the benefits of the updatings.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, we just updated ISAR not too far ago (actually 3 commits in advance).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to align with isar-cip-core's isar commit. I can mention this in commit msg or I can remove this. Just let me know :)

@@ -0,0 +1,24 @@
#
Copy link
Collaborator

@BaochengSu BaochengSu Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name "customizations-" is somehow mis-leading...

Some parts are not customizations, but rather essential patches to fulfill the product definition.

For this one, it implements the defined LED behavior in iot2050 operating instructions.

It's reasonable for downstream to have its own status definition, just I suggest to use iot2050-status-led as the package name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jan-kiszka
Copy link
Collaborator

We also have customizations-base, originally with the idea that this should be something that everyone want to have. Looking at the NODE_PATH it sets, it looks like this diverged as well. This refactoring should cover the base elements as well.

For networking, I would split-off the interface aliases from interface configurations.

#

inherit dpkg-raw

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 1.0 as package version, and also add PR, see ed1ae52

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for others.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is also essential for IOT2050, otherwise the ethernet port number order will be reversed to against the printed label.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I don't think downstream should touch this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved under base packages.

@@ -1,5 +1,5 @@
#
# Copyright (c) Siemens AG, 2019
# Copyright (c) Siemens AG, 2019-2025
#
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make this as "iot2050-nm-settings"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this file is essential as well, otherwise the ttyUSB for the serial port (x30) would change in case of multiple USB-to-serial devices are connected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved under base packages

customizations-network \
customizations-serial-port \
customizations-ssh \
change-root-homedir \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this "change-root-homedir" come from? isar?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comes from isar-cip-core

@BaochengSu
Copy link
Collaborator

We also have customizations-base, originally with the idea that this should be something that everyone want to have. Looking at the NODE_PATH it sets, it looks like this diverged as well. This refactoring should cover the base elements as well.

For networking, I would split-off the interface aliases from interface configurations.

Indeed, also the X30 alias.

- Downstream layers can include what they want easily in this way.

Signed-off-by: Enes Çolpan <[email protected]>
@colpane colpane force-pushed the feature/update-cip-core branch from 391a224 to cf49312 Compare July 11, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants