Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use control flow syntax for examples #110

Merged

Conversation

chintankavathia
Copy link
Member

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@chintankavathia chintankavathia force-pushed the chore/examples-control-flow-syntax branch from c2bd004 to 4cfb44b Compare October 25, 2024 06:47
@chintankavathia chintankavathia marked this pull request as ready for review October 25, 2024 06:52
Copy link
Member

@timowolf timowolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, some minor findings here.

src/app/basic/inline.component.ts Show resolved Hide resolved
src/app/basic/inline.component.ts Show resolved Hide resolved
@chintankavathia chintankavathia force-pushed the chore/examples-control-flow-syntax branch 2 times, most recently from 8376484 to edc56a4 Compare October 25, 2024 09:27
@spike-rabbit
Copy link
Collaborator

Please wait for #112 before merging this one

@chintankavathia chintankavathia force-pushed the chore/examples-control-flow-syntax branch from 5393d9d to 2d7b143 Compare November 8, 2024 06:11
Copy link
Member

@timowolf timowolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timowolf timowolf merged commit 676d029 into siemens:master Nov 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants