refactor: use signals for dimensions #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spike-rabbit
force-pushed
the
refactor/use-signals-for-dimensions
branch
3 times, most recently
from
6be19ab to
36e2e9c
Compare
Copilot finished reviewing on behalf of
fh1ch
November 20, 2025 09:07
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the dimensions management in the datatable component to use Angular signals instead of imperative property updates. The changes move _innerWidth and bodyHeight from regular properties to computed signals, and introduce a new dimensions signal to store the component's width and height.
Key changes:
- Converted
_innerWidthandbodyHeightto computed signals derived from a newdimensionssignal - Simplified
recalculateDims()to only update thedimensionssignal - Updated template to invoke the computed signals as functions
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| datatable.component.ts | Refactored dimensions properties to use signals: introduced dimensions signal, converted _innerWidth and bodyHeight to computed signals, and simplified recalculateDims() method |
| datatable.component.html | Updated template bindings to invoke _innerWidth() and bodyHeight() as signal functions |
| *.png (snapshots) | Updated visual regression test snapshots reflecting minor rendering differences |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fh1ch
force-pushed
the
refactor/use-signals-for-dimensions
branch
from
36e2e9c to
353619a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Imperatively updating the table dimensions and related property by manually calling a function and setting the values.
What is the new behavior?
Moving the dimensions into a signal and using computed for depending values.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
There is more potential for optimization. I will do this in another PR to keep the changes small.
The long-term goal is to update the dimensions using a ResizeObserver.