refactor: convert allRowsSelected into a computed property

[spike-rabbit]

What kind of change does this PR introduce? (check one with "x")

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

allRowsSelected is a getter.

What is the new behavior?

allRowsSelected is a computed signal.

Does this PR introduce a breaking change? (check one with "x")

• Yes
• No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

[gemini-code-assist]

Summary of Changes

Hello @spike-rabbit, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the allRowsSelected property within the DatatableComponent to leverage Angular's computed signal API. This change improves the component's reactivity and potentially its performance by ensuring that the selection state is efficiently re-evaluated only when its dependencies change, without altering the component's external behavior.

Highlights

• Refactor allRowsSelected to a Computed Property: The allRowsSelected property in DatatableComponent has been refactored from a traditional getter to a readonly computed signal. This change aligns with modern Angular reactivity patterns, improving efficiency by re-evaluating only when dependencies change.
• Template Binding Update: The datatable.component.html template was updated to reflect the change in allRowsSelected, now calling it as a function allRowsSelected() to access its value, consistent with how computed signals are accessed in templates.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors allRowsSelected from a getter to a computed signal, which is a good improvement for performance and consistency with Angular Signals. The implementation in the template is correct. However, the logic within the new computed signal, which was copied from the old getter, contains a minor bug and can be simplified. I've suggested a cleaner implementation that also resolves the issue.

[fh1ch]

@spike-rabbit nice and short, thanks a ton, awesome stuff 💚

LGTM 👍

[siemens-element-bot]

🎉 This PR is included in version 25.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀