Retry/Continue on failed search for updating playlist #831
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Error catch JSONDecodeError and retry since json.loads() cannot handle None…
sigma67
reviewed
Nov 17, 2025
| try: | ||
| response_text: JsonDict = json.loads(response.text) | ||
| except json.JSONDecodeError: | ||
| print("JSON parsing failed for song \"" + body["query"] + "\". Probably a 403 or other garbage response. Retrying.") |
Owner
There was a problem hiding this comment.
The error handling here is way too specific and opinionated.
_send_request is used by literally every single function in this library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal of changes to retry send_request when YT returns 403 on searching for a song on a playlist.
Related discussion: #830