-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrap local commands to support different formats #104
Open
davixcky
wants to merge
1
commit into
main
Choose a base branch
from
add-error-wrapper-to-commands
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
package print | ||
|
||
import ( | ||
"fmt" | ||
"github.com/signadot/cli/internal/config" | ||
"io" | ||
) | ||
|
||
func printErrorJson(err error) error { | ||
|
||
return nil | ||
} | ||
|
||
func Error(out io.Writer, err error, outputFormat config.OutputFormat) error { | ||
type errorResponse struct { | ||
Error string `json:"error"` | ||
} | ||
|
||
rawResponse := errorResponse{Error: err.Error()} | ||
|
||
switch outputFormat { | ||
case config.OutputFormatDefault: | ||
return err | ||
case config.OutputFormatJSON: | ||
return RawJSON(out, rawResponse) | ||
case config.OutputFormatYAML: | ||
return RawK8SYAML(out, rawResponse) | ||
default: | ||
return fmt.Errorf("unsupported output format: %q", outputFormat) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this will change the exit status based on the output format, which is odd.
Can we keep the CLI exit status non zero on error? Perhaps using
errors.Join
when json or yaml or the default switch case, combining the argument error with the error result of the encoding would not change the exit code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT on this approach?