add check to access agent-metrics endpoint #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
137
to
140
| cli := &http.Client{ | ||
| Transport: &http.Transport{}, | ||
| } |
There was a problem hiding this comment.
Maybe it is worth configuring a timeout here?
There was a problem hiding this comment.
I added a timeout and made a couple of other changes and fixes:
- access agent-metrics (we don't have any health endpoints exposed, this was always restarting)
- make the health more pessimistic, return unhealthy when restart is needed
daniel-de-vera
approved these changes
Dec 20, 2024
This is intended as minimal change to fix signadot/signadot#5172 tested with warp, it causes restarts and we are able to connect whereas previously it hangs still to consider: - do we need to make this visible in status? - do we need to make check period configurable? add check to agent-metrics endpoints in tp monitor
scott-cotton
force-pushed
the
local-status-improvements
branch
from
7e8ac89 to
ed05c99
Compare
scott-cotton
changed the title
thanks, I made a couple of changes after more testing. could you look again? |
Yes, still LGTM. |
|
More testing revealed the status visibility pessimism is too pessimistic sometimes, looking at that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended as minimal change to fix
https://github.com/signadot/signadot/issues/5172
tested with warp, it causes restarts and we are able to connect whereas previously it hangs
regarding discussion around:
do we need to make this visible in status?
I changed it so that it is more visible in status, returning unhealthy when a restart is needed instead of healthy.
do we need to make check period configurable?
I think not, because it is actually complicated because there 2 check periods for healthy and unhealthy state. Also, the check period relates to the timeout for the added checking request.