Skip to content

NotificationProfile Icon visibility updates from all tabs#13945

Closed
Sagar0-0 wants to merge 1 commit intosignalapp:mainfrom
Sagar0-0:notif-profile-visibility
Closed

NotificationProfile Icon visibility updates from all tabs#13945
Sagar0-0 wants to merge 1 commit intosignalapp:mainfrom
Sagar0-0:notif-profile-visibility

Conversation

@Sagar0-0
Copy link
Contributor

First time contributor checklist

Contributor checklist

  • Device A, Android X.Y.Z
  • Device B, Android Z.Y
  • Virtual device W, Android Y.Y.Z
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

  1. Create and enable a Notifiation profile to see the sleep icon in the topbar.
  2. Clicking on it opens the bottom sheet and disabling the notification profile removes the icon from topbar.
  3. This behavior is only observed from the ConversationListFragment, means call and status screen can't update sleep icon visibility state.

I moved the logic to MainActivityListHostFragment.

Before:

document_6104666523677233673.mp4

After:

document_6104666523677233678.mp4

Copy link
Contributor

@greyson-signal greyson-signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thank you! Will go out in 7.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants