Ensure color column exists before query in legacy DB migration #14518
+12
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Fixes #1234syntaxDescription
I have an old-ish Android 6.x device that I previously used Signal on. The database schema has gotten into a state where the
updateSystemContactColorsmigration fails due to a missingcolorcolumn on therecipienttable.The failure prevents the Signal user interface from opening, locking me out of historical conversations and media I'd like to retain.
That database migration has been deprecated since Y2021 (ref: bcc5d48).
This pull request adds an error-ignored step to add the column before it is queried (as far as I know, SQLite has no
add column if not existsfunctionality). I have not yet tested this, but believe that it would solve the problem.I have not been able to decrypt the database from my device to test this with, and I am not keen to root the device purely to install an unsigned test build.
May resolve #14228.